Adding possibility to configure sass generation directories #71
+38
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default "sass" files should be stored in a "sass" directory in stylesheet's directory and generated "css" files are saved in stylesheet's directory. The idea is not to have generated "css" stored in same directory as the others and to allow "sass" to be stored in the root stylesheet's directory of themes. Both directory can be set in config as "css_cache_dir" and "sass_dir" eg: all "css" can be saved in a specific cache directory "config.css_cache_dir = :root/tmp/cache/themes_for_rails/:name/stylesheets"
To prevent doted filename to return a 404 error, extension comparison is now done with mime type extension and not "blank?"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default "sass" files should be stored in a "sass" directory in stylesheet's directory and generated "css" files are saved in stylesheet's directory.
The idea is not to have generated "css" stored in same directory as the others and to allow "sass" to be stored in the root stylesheet's directory of themes.
Both directory can be set in config as "css_cache_dir" and "sass_dir"
eg: all "css" can be saved in a specific cache directory "config.css_cache_dir = :root/tmp/cache/themes_for_rails/:name/stylesheets"